From 6eef5a0f469ce9543862ce163b38b44bff3ea738 Mon Sep 17 00:00:00 2001 From: MiniDay <372403923@qq.com> Date: Thu, 16 Feb 2023 06:36:31 +0800 Subject: [PATCH] =?UTF-8?q?perf(bukkit):=20=E4=BC=98=E5=8C=96=E4=BB=A3?= =?UTF-8?q?=E7=A0=81?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../plugin/core/bukkit/command/ParentCommand.java | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/hamster-core-bukkit/src/main/java/cn/hamster3/mc/plugin/core/bukkit/command/ParentCommand.java b/hamster-core-bukkit/src/main/java/cn/hamster3/mc/plugin/core/bukkit/command/ParentCommand.java index d0751a5..f8d1f79 100644 --- a/hamster-core-bukkit/src/main/java/cn/hamster3/mc/plugin/core/bukkit/command/ParentCommand.java +++ b/hamster-core-bukkit/src/main/java/cn/hamster3/mc/plugin/core/bukkit/command/ParentCommand.java @@ -140,11 +140,11 @@ public abstract class ParentCommand extends ChildCommand { if (!childCommand.getName().equalsIgnoreCase(args[0])) { continue; } - if (childCommand instanceof ParentCommand || childCommand.hasPermission(sender)) { - return childCommand.onCommand(sender, command, label, Arrays.copyOfRange(args, 1, args.length)); + if (!childCommand.hasPermission(sender)) { + CoreMessage.COMMAND_NOT_HAS_PERMISSION.show(sender); + return true; } - CoreMessage.COMMAND_NOT_HAS_PERMISSION.show(sender); - return true; + return childCommand.onCommand(sender, command, label, Arrays.copyOfRange(args, 1, args.length)); } CoreMessage.COMMAND_NOT_FOUND.show(sender); return true; @@ -152,12 +152,6 @@ public abstract class ParentCommand extends ChildCommand { @Override public List onTabComplete(@NotNull CommandSender sender, @NotNull Command command, @NotNull String alias, String[] args) { - if (args.length == 0) { - return childCommands.stream() - .filter(o -> o.hasPermission(sender)) - .map(ChildCommand::getName) - .collect(Collectors.toList()); - } for (ChildCommand child : childCommands) { if (args[0].equalsIgnoreCase(child.getName())) { return child.onTabComplete(sender, command, alias, Arrays.copyOfRange(args, 1, args.length));