MiniDay/Velocity
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix packet decode logging not giving useful errors

Browse Source 
See #349 for context
This commit is contained in:
Andrew Steinborn
2020-08-06 07:42:42 -04:00
parent 3beaeb2df7
commit b2d9e11217
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
proxy/src/main/java/com/velocitypowered/proxy/connection/MinecraftConnection.java
View File

@@ -157,9 +157,9 @@ public class MinecraftConnection extends ChannelInboundHandlerAdapter {
logger.error("{}: read timed out", association); logger.error("{}: read timed out", association);
} else { } else {
boolean isQuietDecoderException = cause instanceof QuietDecoderException; boolean isQuietDecoderException = cause instanceof QuietDecoderException;
boolean willLogQuietDecoderException = isQuietDecoderException boolean willLogQuietDecoderException = MinecraftDecoder.DEBUG || (isQuietDecoderException
&& !(sessionHandler instanceof LoginSessionHandler) && !(sessionHandler instanceof LoginSessionHandler)
&& !(sessionHandler instanceof HandshakeSessionHandler); && !(sessionHandler instanceof HandshakeSessionHandler));
if (willLogQuietDecoderException) { if (willLogQuietDecoderException) {
logger.error("{}: exception encountered in {}", association, sessionHandler, cause); logger.error("{}: exception encountered in {}", association, sessionHandler, cause);
} else if (isQuietDecoderException) { } else if (isQuietDecoderException) {