Added ProxyConfig interface and implemented in VelocityConfiguration

proxy/src/main/java/com/velocitypowered/proxy/config/VelocityConfiguration.java

@@ -3,6 +3,7 @@ package com.velocitypowered.proxy.config;
 import com.google.common.base.MoreObjects;
 import com.google.common.collect.ImmutableMap;
 import com.moandjiezana.toml.Toml;
+import com.velocitypowered.api.proxy.config.ProxyConfig;
 import com.velocitypowered.api.util.Favicon;
 import com.velocitypowered.proxy.util.AddressUtil;
 import net.kyori.text.Component;
@@ -18,7 +19,7 @@ import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.util.*;
 
-public class VelocityConfiguration extends AnnotatedConfig {
+public class VelocityConfiguration extends AnnotatedConfig implements ProxyConfig {
 
     @Comment("Config version. Do not change this")
     @ConfigKey("config-version")
@@ -263,8 +264,8 @@ public class VelocityConfiguration extends AnnotatedConfig {
         return advanced.getLoginRatelimit();
     }
 
-    public Favicon getFavicon() {
-        return favicon;
+    public Optional<Favicon> getFavicon() {
+        return Optional.ofNullable(favicon);
     }
 
     public boolean isAnnounceForge() {

proxy/src/main/java/com/velocitypowered/proxy/connection/backend/VelocityServerConnection.java

@@ -21,7 +21,6 @@ import com.velocitypowered.proxy.protocol.packet.PluginMessage;
 import com.velocitypowered.proxy.protocol.packet.ServerLogin;
 import com.velocitypowered.proxy.server.VelocityRegisteredServer;
 import io.netty.channel.Channel;
-import io.netty.channel.ChannelFuture;
 import io.netty.channel.ChannelFutureListener;
 import io.netty.channel.ChannelInitializer;
 import io.netty.handler.timeout.ReadTimeoutHandler;

proxy/src/main/java/com/velocitypowered/proxy/connection/client/LoginSessionHandler.java

@@ -15,7 +15,6 @@ import com.velocitypowered.proxy.config.PlayerInfoForwarding;
 import com.velocitypowered.proxy.connection.MinecraftConnection;
 import com.velocitypowered.proxy.connection.MinecraftSessionHandler;
 import com.velocitypowered.proxy.connection.VelocityConstants;
-import com.velocitypowered.proxy.protocol.MinecraftPacket;
 import com.velocitypowered.proxy.protocol.ProtocolConstants;
 import com.velocitypowered.proxy.protocol.StateRegistry;
 import com.velocitypowered.proxy.protocol.packet.*;

proxy/src/main/java/com/velocitypowered/proxy/connection/client/StatusSessionHandler.java

@@ -41,7 +41,7 @@ public class StatusSessionHandler implements MinecraftSessionHandler {
                 new ServerPing.Version(shownVersion, "Velocity " + ProtocolConstants.SUPPORTED_GENERIC_VERSION_STRING),
                 new ServerPing.Players(server.getPlayerCount(), configuration.getShowMaxPlayers(), ImmutableList.of()),
                 configuration.getMotdComponent(),
-                configuration.getFavicon(),
+                configuration.getFavicon().orElse(null),
                 configuration.isAnnounceForge() ? ServerPing.ModInfo.DEFAULT : null
         );