Properly pass connection exceptions to the logger

This commit is contained in:
Shane Freeder
2024-05-01 17:22:18 +01:00
parent 399bc2325f
commit 5cdcf86cf9

View File

@@ -195,8 +195,9 @@ public class MinecraftConnection extends ChannelInboundHandlerAdapter {
boolean isQuietDecoderException = cause instanceof QuietDecoderException; boolean isQuietDecoderException = cause instanceof QuietDecoderException;
boolean willLog = !isQuietDecoderException && !frontlineHandler; boolean willLog = !isQuietDecoderException && !frontlineHandler;
if (willLog) { if (willLog) {
logger.error("{}: exception encountered in {}", association, activeSessionHandler, logger.atError().withThrowable(cause)
cause); .log("{}: exception encountered in {}", association,
activeSessionHandler);
} else { } else {
knownDisconnect = true; knownDisconnect = true;
} }
@@ -226,7 +227,6 @@ public class MinecraftConnection extends ChannelInboundHandlerAdapter {
* Writes and immediately flushes a message to the connection. * Writes and immediately flushes a message to the connection.
* *
* @param msg the message to write * @param msg the message to write
*
* @return A {@link ChannelFuture} that will complete when packet is successfully sent * @return A {@link ChannelFuture} that will complete when packet is successfully sent
*/ */
@Nullable @Nullable