MiniDay/Velocity
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Avoid ByteBuf#slice(). We can simply reset the reader index.

Browse Source
This commit is contained in:
Andrew Steinborn
2019-01-12 00:25:11 -05:00
parent 1a2b162353
commit 564b87de1d
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
proxy/src/main/java/com/velocitypowered/proxy/protocol/netty/MinecraftVarintFrameDecoder.java
View File

@@ -17,7 +17,7 @@ public class MinecraftVarintFrameDecoder extends ByteToMessageDecoder {
return;
}
ByteBuf lenBuf = ctx.alloc().buffer(3);
ByteBuf lenBuf = ctx.alloc().buffer(3).writeZero(3);
int origReaderIndex = in.readerIndex();
try {
for (int i = 0; i < 3; i++) {
@@ -27,9 +27,11 @@ public class MinecraftVarintFrameDecoder extends ByteToMessageDecoder {
}
byte read = in.readByte();
lenBuf.writeByte(read);
lenBuf.setByte(i, read);
if (read > 0) {
int packetLength = ProtocolUtils.readVarInt(lenBuf.slice());
// Make sure reader index of length buffer is returned to the beginning
lenBuf.readerIndex(0);
int packetLength = ProtocolUtils.readVarInt(lenBuf);
if (packetLength == 0) {
return;
}