Make announce-player-commands not suggest aliases

Fixes #533

proxy/src/main/java/com/velocitypowered/proxy/VelocityServer.java

@@ -247,6 +247,8 @@ public class VelocityServer implements ProxyServer, ForwardingAudience {
         LogManager.shutdown();
         System.exit(1);
       }
+
+      commandManager.setAnnounceProxyCommands(configuration.isAnnounceProxyCommands());
     } catch (Exception e) {
       logger.error("Unable to read/load/save your velocity.toml. The server will shut down.", e);
       LogManager.shutdown();
@@ -384,6 +386,7 @@ public class VelocityServer implements ProxyServer, ForwardingAudience {
           newConfiguration.getQueryPort());
     }
 
+    commandManager.setAnnounceProxyCommands(newConfiguration.isAnnounceProxyCommands());
     ipAttemptLimiter = Ratelimiters.createWithMilliseconds(newConfiguration.getLoginRatelimit());
     this.configuration = newConfiguration;
     eventManager.fireAndForget(new ProxyReloadEvent());

proxy/src/main/java/com/velocitypowered/proxy/command/SuggestionsProvider.java

@@ -33,6 +33,7 @@ import com.spotify.futures.CompletableFutures;
 import com.velocitypowered.api.command.Command;
 import com.velocitypowered.api.command.CommandMeta;
 import com.velocitypowered.api.command.CommandSource;
+import com.velocitypowered.api.proxy.Player;
 import com.velocitypowered.proxy.command.brigadier.VelocityArgumentCommandNode;
 import java.util.ArrayList;
 import java.util.Collection;
@@ -62,10 +63,12 @@ final class SuggestionsProvider<S> {
 
   private final @GuardedBy("lock") CommandDispatcher<S> dispatcher;
   private final Lock lock;
+  private boolean announceProxyCommands;
 
   SuggestionsProvider(final CommandDispatcher<S> dispatcher, final Lock lock) {
     this.dispatcher = Preconditions.checkNotNull(dispatcher, "dispatcher");
     this.lock = Preconditions.checkNotNull(lock, "lock");
+    this.announceProxyCommands = true;
   }
 
   /**
@@ -149,6 +152,10 @@ final class SuggestionsProvider<S> {
     // TODO Is this actually faster? It may incur an allocation
     final String input = reader.getRead().toLowerCase(Locale.ENGLISH);
 
+    if (source instanceof Player && !this.announceProxyCommands) {
+      return new SuggestionsBuilder(input, 0).buildFuture();
+    }
+
     final Collection<CommandNode<S>> aliases = contextSoFar.getRootNode().getChildren();
     @SuppressWarnings("unchecked")
     final CompletableFuture<Suggestions>[] futures = new CompletableFuture[aliases.size()];
@@ -368,4 +375,13 @@ final class SuggestionsProvider<S> {
       return Suggestions.merge(fullInput, suggestions);
     });
   }
+
+  /**
+   * Sets a flag indicating whether or not alias suggestions shall be returned to the user.
+   *
+   * @param announceProxyCommands whether alias suggestions can be returned
+   */
+  public void setAnnounceProxyCommands(boolean announceProxyCommands) {
+    this.announceProxyCommands = announceProxyCommands;
+  }
 }

proxy/src/main/java/com/velocitypowered/proxy/command/VelocityCommandManager.java

@@ -77,6 +77,10 @@ public class VelocityCommandManager implements CommandManager {
     this.injector = new CommandGraphInjector<>(this.dispatcher, this.lock.readLock());
   }
 
+  public void setAnnounceProxyCommands(boolean announceProxyCommands) {
+    this.suggestionsProvider.setAnnounceProxyCommands(announceProxyCommands);
+  }
+
   @Override
   public CommandMeta.Builder metaBuilder(final String alias) {
     Preconditions.checkNotNull(alias, "alias");

proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/AvailableCommands.java

@@ -43,7 +43,6 @@ import com.velocitypowered.proxy.protocol.packet.brigadier.ArgumentPropertyRegis
 import com.velocitypowered.proxy.util.collect.IdentityHashStrategy;
 import io.netty.buffer.ByteBuf;
 import it.unimi.dsi.fastutil.objects.Object2IntLinkedOpenCustomHashMap;
-import it.unimi.dsi.fastutil.objects.Object2IntLinkedOpenHashMap;
 import it.unimi.dsi.fastutil.objects.Object2IntMap;
 import java.util.ArrayDeque;
 import java.util.Arrays;